Add actions to notifications #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh okay, CI is failing in a really weird way, complaining that |
FoamyGuy
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Neat! thanks for the new functionality @todbot! Thank you for including the example of this as well.
These changes look good to me. Don't have an iOS device to test with, but code makes sense to me.
Sometimes the version of one or more of the tools that CI runs changes on us and then causes failures on code that is otherwise untouched by a PR, my guess is that took place here. Thanks for getting it squared away.
evaherrada
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 11, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.12 from 1.1.11: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#22 from rivimey/convrate_docstring > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.5 from 5.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#88 from awgrover/unsubscribe-group-key-87 > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center to 0.10.0 from 0.9.7: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Apple_Notification_Center#16 from todbot/add_actions > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications have optional "positive action" and "negative action" responses.
This PR adds those actions to the
adafruit_ble_apple_notification_center.Notificationclass.This allows, for instance, the ability to accept or decline IncomingCalls and to hang up ActiveCalls.
This PR also adds a new category ID description of "ActiveCall" for category_id=12, which was introduced in iOS 13.
An example is provided that works on Circuit Playground Bluefruit.
Demo of it in action here: https://twitter.com/todbot/status/1511483283493687296