Skip to content

add Adafruit Feather nRF52840 Sense to doc #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

dglaude
Copy link
Contributor

@dglaude dglaude commented Aug 28, 2020

No description provided.

@ladyada ladyada requested a review from dhalbert August 28, 2020 15:26
@dglaude
Copy link
Contributor Author

dglaude commented Aug 28, 2020

Ok, maybe this can be done manually after the fix to the code has been done... I don't want to rebase or whatever.
Further fix will have to wait.

Actually other BLE related library are not listing all the product that would use that, such as https://github.com/adafruit/Adafruit_CircuitPython_BLE/blob/master/docs/index.rst

Maybe it does not make sense (punt intended) to list all of the BLE product... where do you stop? Itsy-Bitsy? What Else?

@dhalbert
Copy link
Contributor

Why don't you just remove the product list. The app will actually accept any product. You could close this and remove the list. I merged the other PR so the import order issues should go away now.

@dglaude dglaude closed this Aug 28, 2020
@dglaude
Copy link
Contributor Author

dglaude commented Aug 28, 2020

I don't know what is the policy for the product list in documentation... but as library get's old and new product come in, this get out of date.

@dhalbert dhalbert reopened this Aug 28, 2020
@dhalbert
Copy link
Contributor

OK, I just removed the "Related Products" list.

@dhalbert dhalbert merged commit 922916a into adafruit:master Aug 28, 2020
@dglaude dglaude deleted the patch-2 branch August 28, 2020 19:15
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 29, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#8 from dglaude/patch-2
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#7 from dglaude/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#11 from makermelissa/json_path
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#10 from makermelissa/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants