Skip to content

Increase default connect timeout to 10 seconds #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Apr 3, 2023

4 seconds, the previous default connect timeout, was too short sometimes, when testing blinka_bleio with bleak 0.20.1. See adafruit/Adafruit_Blinka_bleio#58 (comment)

4 seconds, the previous default connect timeout, was too short sometimes, when testing blinka_bleio with `bleak 0.20.1`.
@dhalbert dhalbert requested a review from a team April 3, 2023 20:33
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me!

@dhalbert dhalbert merged commit 1346829 into main Apr 3, 2023
@dhalbert dhalbert deleted the dhalbert-patch-1 branch April 3, 2023 20:43
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 4, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.0 from 9.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#184 from adafruit/dhalbert-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 2.4.0 from 2.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#43 from michalpokusa/feature/url_parameters

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants