Skip to content

Extend hid descriptor maximum to make international keyboard #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Extend hid descriptor maximum to make international keyboard #105

merged 1 commit into from
Sep 21, 2020

Conversation

yswallow
Copy link
Contributor

This enables sending keycode 0x87( e.g. backslash in Japanese keyboard ) etc.

@dhalbert
Copy link
Collaborator

Perhaps we should make this 255, since there are other possible keys that are greater. See https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf, page 59. Do you know if there's some reason not to do that?

@yswallow
Copy link
Contributor Author

While I don't know much about HID devices, I found three points.

  1. Adafruit_CircuitPython_HID/keycode.py is up to 0x65, the same.
  2. This PullReq is up to 0x89, but Japanese MUHENKAN key is 0x91, not enough.
  3. keycode 0xE0 and greater are modifier keys. So no need to append this usage page.

I tested 0xB0 to 0xCE, only 0xB9 and 0xBC are effective. ( I mean, if the keys don't work properly, we should not extend the range. )

0xB9 is defined as keypad }, but opened open... menu.
0xBC is defined as keypad A, but opened save... menu.

@tannewt
Copy link
Member

tannewt commented Sep 21, 2020

This change looks good to me. @dhalbert is on vacation and may want to follow up later.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yswallow

@tannewt tannewt merged commit 8bb1210 into adafruit:master Sep 21, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 26, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.2 from 1.0.1:
  > updated example to include python serial setup

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#15 from spkuehl/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.3.1 from 7.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#105 from yswallow/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#10 from adafruit/tannewt-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants