Skip to content

Added typing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2021
Merged

Added typing #6

merged 5 commits into from
Nov 13, 2021

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Nov 5, 2021

No description provided.

@tekktrik
Copy link
Member Author

tekktrik commented Nov 5, 2021

Not entirely sure how to handle this build failure, but happy to stay posted!

@tannewt tannewt requested a review from a team November 8, 2021 17:48
@tekktrik
Copy link
Member Author

Added _bleio to the mock imports in docs/conf.py, just want to make sure that's the correct solution here

@dhalbert
Copy link
Contributor

You can add adafruit-blinka-bleio to the requirements, that should work as well, and will have better checking.

@tekktrik
Copy link
Member Author

Tried adding adafruit-blinka-bleio to the docs/requirements.txt in a test branch and removing the mock import and it failed again: https://github.com/tekktrik/Adafruit_CircuitPython_AirLift/actions/runs/1453446829

It looked like that requirement was already in the library requirements.txt too

@dhalbert
Copy link
Contributor

Ah, too bad, it's because the CI machine can't run a Bluetooth utility we need:
FileNotFoundError: [Errno 2] No such file or directory: 'bluetoothctl': 'bluetoothctl'. OK, then just use the mock.

dhalbert
dhalbert requested changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just -> None

FoamyGuy
FoamyGuy approved these changes Nov 13, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. It appears all of the requested changes have been completed.

@FoamyGuy FoamyGuy merged commit 8bfc83c into adafruit:main Nov 13, 2021
@FoamyGuy FoamyGuy mentioned this pull request Nov 13, 2021
Closed
4 tasks
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 14, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
96e5585 
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.2.8 from 2.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#36 from fivesixzero/type-annotations
  > Updated readthedocs file
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#34 from fivesixzero/remove-unused-interrupt-pin-arg
  > Disabled unspecified-encoding pylint check
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#35 from adafruit/patch-test
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_AirLift to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AirLift#6 from tekktrik/feature/add-typing
  > Updated readthedocs file
  > Disabled unspecified-encoding pylint check
  > PATCH Pylint and readthedocs patch test
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert requested changes

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekktrik @dhalbert @FoamyGuy