Skip to content

Remove adafruit_esp32spi_wifimanager import dependency #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 25, 2019

Removing

if isinstance(wifi_manager, adafruit_esp32spi_wifimanager.ESPSPI_WiFiManager):

in favor of

if ('ESPSPI_WiFiManager' in wifi_type or 'ESPAT_WiFiManager' in wifi_type):

The library won't need to import adafruit_esp32spi_wifimanager, and this'll add more flexibility for future types of WiFiManager classes (such as the ESPAT_WiFiManager @jerryneedell is working on. I've added support for that)

  • also removing autodoc_mock_imports from sphinx configuration, required by adafruit_esp32spi_wifimanager's neopixel dependency

@brentru brentru added the enhancement New feature or request label Feb 25, 2019
@brentru brentru requested review from jerryneedell and a team February 25, 2019 16:14
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! tested with ESPAT_WiFiManager version under development

@brentru
Copy link
Member Author

brentru commented Feb 25, 2019

Thanks for testing @jerryneedell. Merging in

@brentru brentru merged commit e95cda3 into adafruit:master Feb 25, 2019
@brentru brentru deleted the wifi-manager-instance branch February 25, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants