Skip to content

change settings to secrets #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 23, 2019

No description provided.

@brentru brentru requested review from jerryneedell and a team February 23, 2019 23:24
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename is just 'secrets.py'!

@@ -12,11 +12,11 @@
# Import Adafruit IO REST Client
from adafruit_io.adafruit_io import RESTClient, AdafruitIO_RequestError

# Get wifi details and more from a wifi_settings.py.py file
# Get wifi details and more from a esp32spi_secrets.py.py file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 'secrets.py' please - that way it matches pyportal's expectations!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, only secrets now - was looking at ESP32 at the time.

Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@brentru brentru merged commit 0c6c947 into adafruit:master Feb 25, 2019
@brentru brentru deleted the settings-secrets branch February 25, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants