Skip to content

Clarify feed callback docstrings #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2020
Merged

Clarify feed callback docstrings #47

merged 2 commits into from
Nov 3, 2020

Conversation

brentru
Copy link
Member

@brentru brentru commented Sep 30, 2020

Attempt to clarify add_feed_callback and remove_feedback functionality via docstrings, per @tannewt 's review here: #46

@brentru brentru requested a review from tannewt September 30, 2020 16:49
@brentru brentru mentioned this pull request Sep 30, 2020
Merged
tannewt
tannewt requested changes Sep 30, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! Just a couple comments.

tannewt
tannewt approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit ce611ae into adafruit:master Nov 3, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 5, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c01bb3a)
9d2ab36 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.2.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#7 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.2.2 from 4.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#47 from brentru/update-docstring-callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @tannewt