Skip to content

Fixes per sommersoft's review #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 22, 2019

  • Added explicit check for the wifi kwarg against adafruit_esp32spi_wifimanager.ESPSPI_WiFiManager to make sure it's it's an instance of _WiFiManager, not something else accidentally passed in
  • Changed api.rst to reflect directory structure
  • Changed _compose_path to a more readable path.

Changes requested per: #1

@brentru brentru added the enhancement New feature or request label Feb 22, 2019
@brentru brentru requested a review from sommersoft February 22, 2019 23:08
Copy link
Collaborator

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking over the Travis build, and it's Sphinx failure on line #388, autodoc is failing on the import of neopixel contained in adafruit_esp32spi, which is imported in adafruit_io.py.

Since requirements.txt pip installs adafruit_esp32spi on the Travis instance, Sphinx can locate that module in the sys.path. However, neopixel isn't available in the sys.path, since that CircuitPython module isn't pulled into the instance.

There are two options here:

  1. add CircuitPython to the intersphinx mapping. Example
  2. add an autodoc_mock_imports including neopixel to conf.py.

@brentru
Copy link
Member Author

brentru commented Feb 25, 2019

Travis is passing, merging into master

@brentru brentru merged commit 26c4f29 into adafruit:master Feb 25, 2019
@brentru brentru deleted the sommersoft-pr-patches branch February 25, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants