Skip to content

Update variable names in examples for default secrets.py #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2019
Merged

Update variable names in examples for default secrets.py #18

merged 2 commits into from
Mar 14, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Mar 11, 2019

Changing username and key strings in examples to match the default IO naming within secrets.py: https://github.com/adafruit/Adafruit_CircuitPython_PyPortal/blob/master/adafruit_pyportal.py#L518

@brentru brentru requested a review from a team March 11, 2019 16:40
@kattni kattni mentioned this pull request Mar 12, 2019
Open
jerryneedell
jerryneedell approved these changes Mar 13, 2019
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I have not tested these, but have no concern with the changes.

@brentru brentru merged commit 566a9ac into adafruit:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @jerryneedell