Skip to content

add user-agent to http header string, remove header byte encoding #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2019
Merged

add user-agent to http header string, remove header byte encoding #17

merged 1 commit into from
Mar 12, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Mar 11, 2019

Custom header encoding was fixed in ESP32SPI (https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI/releases/tag/1.3.4). This PR drops explicit byte-encoding for headers.

  • Append User-Agent for this library onto existing request headers.
  • New _create_headers method, referenced in HTTP get/post/delete client actions

@brentru brentru added the enhancement New feature or request label Mar 11, 2019
@brentru brentru requested a review from a team March 11, 2019 16:29
@kattni kattni mentioned this pull request Mar 12, 2019
Open
jerryneedell
jerryneedell approved these changes Mar 12, 2019
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Ran a test of the adafruit_io_simpletest_weather demo on a PyPortal -- worked fine.

@brentru brentru merged commit b00f674 into adafruit:master Mar 12, 2019
@jerryneedell jerryneedell mentioned this pull request Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @jerryneedell