Skip to content

Updated examples to reflect neopixel abstraction #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 26, 2019

Conversation

makermelissa
Copy link
Collaborator

This should be tested along with PR adafruit/Adafruit_CircuitPython_ESP32SPI#14

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that the examples submitted work as expected on PyPortal running the updated WiFiManager.

Before I pull in, please also update the analog_in.py example: https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/master/examples/adafruit_io_simpletest_analog_in.py

@makermelissa makermelissa requested a review from brentru February 26, 2019 20:05
@makermelissa
Copy link
Collaborator Author

Heh, it's amazing how much you can do from the github web interface.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All examples look good, merging into master

@brentru brentru merged commit 7fd0783 into adafruit:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants