Skip to content

Update examples for PyPortal board., default examples to pyportal #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 25, 2019

  • Removed microcontroller pin definitions in favor of nicer PyPortal board. pin names for all examples.
  • Comment out ESP32 example pin setup, uncomment PyPortal.

Addressing #9

Tested on a PyPortal running CircuitPython 4.0.0b2 latest.

@brentru brentru requested a review from a team February 25, 2019 22:01
@brentru
Copy link
Member Author

brentru commented Feb 26, 2019

I'm going to revert the commit for keeping PyPortal as default for examples, support generic ESP32 setup first.

@makermelissa
Copy link
Collaborator

Hiya, that's good. I'm making a change to the ESP32SPI library that affects this library and have been updating the examples to reflect this. Hopefully no merge conflicts coming.

@brentru
Copy link
Member Author

brentru commented Feb 26, 2019

@makermelissa Thanks! I'll test with this library when you're ready.

@brentru brentru merged commit 5c04b04 into adafruit:master Feb 26, 2019
@brentru brentru deleted the update-pyportal-pindefs branch February 26, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants