Skip to content

Check nina-fw version in code #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Conversation

brentru
Copy link
Member

@brentru brentru commented Oct 21, 2019

This library requires nina-fw version 1.4.0 or above. Instead of checking the MiniMQTT's wifi client attribute, check the nina-fw version from within the code.

Notes:

  • Remove nina-fw check within library, check version in code instead
  • Remove set_certificate and set_private_key check within library, example code calls these two methods.

@ladyada ladyada merged commit cbbb47e into adafruit:master Oct 21, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 21, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#4 from brentru/version-check-code
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#3 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants