Skip to content

move bytearray.fromhex to ubinascii.unhexlify #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

move bytearray.fromhex to ubinascii.unhexlify #26

merged 2 commits into from
Oct 6, 2021

Conversation

silvester
Copy link
Contributor

@silvester silvester commented Oct 5, 2021 •
edited
Loading

Should fix issue 24. Tested it locally with macropad and atecc608, works as expected. Tested on CircuitPython 7.0.0.

@ladyada ladyada requested a review from brentru October 5, 2021 20:53
brentru
brentru approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me as unhexlify and fromhex are functionally the same, and this PR addresses the issue.

Similar functionality (accepting only text string arguments, but more liberal towards whitespace) is also accessible using the bytes.fromhex() class method. via https://docs.python.org/3/library/binascii.html#binascii.unhexlify

@brentru
Copy link
Member

brentru commented Oct 5, 2021

@silvester Hi - thank you for submitting a PR, it looks OK to merge but is failing our CI:
https://github.com/adafruit/Adafruit_CircuitPython_ATECC/pull/26/checks?check_run_id=3808028101#step:11:28

Could you please run black over adafruit_atecc/adafruit_atecc.py and add a commit with the formatted file? We have a guide for this here: https://learn.adafruit.com/improve-your-code-with-pylint/black

@silvester
Copy link
Contributor Author

Thanks for the guide. Have run the code through black and reformatted my changes.

@silvester silvester requested a review from brentru October 6, 2021 13:21
@brentru brentru merged commit 06b6a78 into adafruit:main Oct 6, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 8, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b005706)
ae96975 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ATECC to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ATECC#26 from silvester/main
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#9 from adafruit/pb-color-order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvester @brentru