Setting LED current

[DaveLangstaff]

Setting the LED current to 0, with sensor.led_current=0 gives the unexpected result of actually setting the current to the maximum value possible, due to wrap around in the calculation.

Suggest modifying line 620 of file to:

    new_current = max(0, min(127,int((led_curent - 4) / 1)))

to coerce current being set to valid range.

regards
dave Langstaff

[ladyada]

! could you submit a PR please? :)

[DaveLangstaff]

Hi, Sorry, I’m new to this – submit a PR? Regards Dave Langstaff From: ladyada <notifications@github.com> Sent: 07 December 2020 15:17 To: adafruit/Adafruit_CircuitPython_AS7341 <Adafruit_CircuitPython_AS7341@noreply.github.com> Cc: Dave Langstaff [dpl] <dpl@aber.ac.uk>; Author <author@noreply.github.com> Subject: Re: [adafruit/Adafruit_CircuitPython_AS7341] Setting LED current (#1) [RHYBUDD! E-BOST ALLANOL / CAUTION! EXTERNAL E-MAIL] ! could you submit a PR please? :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadafruit%2FAdafruit_CircuitPython_AS7341%2Fissues%2F1%23issuecomment-739982122&data=04%7C01%7C%7C112135aa70be478b989808d89ac3360c%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C1%7C637429510498936725%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3OvnIlN5Py2m3BcuQ66Z8Kw4xFVK29oYrubCxBgqFXU%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACTK76TRI47EDT5SQHVNBWDSTTWYPANCNFSM4UQJJAQQ&data=04%7C01%7C%7C112135aa70be478b989808d89ac3360c%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C1%7C637429510498946674%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1Z%2Fo1PblqOba%2BgGUu46xUMTxolVZ5WRL4r%2F90GRDRrI%3D&reserved=0>.

…

---------------------------------------------------------------------------------------------------------------------- Prifysgol y Flwyddyn ar gyfer Ansawdd y Dysgu a Phrofiad Myfyrwr University of the year for Teaching Quality and Student Experience (The Times and Sunday Times, Good University Guide 2021) Rydym yn croesawu gohebiaeth yn Gymraeg a Saesneg. Cewch ateb Cymraeg i bob gohebiaeth Gymraeg ac ateb Saesneg i bob gohebiaeth Saesneg. Ni fydd gohebu yn Gymraeg yn arwain at oedi. We welcome correspondence in Welsh and English. Correspondence received in Welsh will be answered in Welsh and correspondence in English will be answered in English. Corresponding in Welsh will not involve any delay.

[ladyada]

yep contribute your fix!
https://learn.adafruit.com/an-introduction-to-collaborating-with-version-control
https://learn.adafruit.com/contribute-to-arduino-with-git-and-github

[DaveLangstaff]

Many thanks, I’ll work through the guide and send in the fix Regards Dave Langstaff From: ladyada <notifications@github.com> Sent: 07 December 2020 16:10 To: adafruit/Adafruit_CircuitPython_AS7341 <Adafruit_CircuitPython_AS7341@noreply.github.com> Cc: Dave Langstaff [dpl] <dpl@aber.ac.uk>; Author <author@noreply.github.com> Subject: Re: [adafruit/Adafruit_CircuitPython_AS7341] Setting LED current (#1) [RHYBUDD! E-BOST ALLANOL / CAUTION! EXTERNAL E-MAIL] yep contribute your fix! https://learn.adafruit.com/an-introduction-to-collaborating-with-version-control<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.adafruit.com%2Fan-introduction-to-collaborating-with-version-control&data=04%7C01%7C%7Cecbe22b049fd4e7ac46508d89aca811a%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637429541821265044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Y%2BrXZSy7AxQ9RX2YIo%2BcfwOJHrLWk8jEgpByufp7Ils%3D&reserved=0> https://learn.adafruit.com/contribute-to-arduino-with-git-and-github<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.adafruit.com%2Fcontribute-to-arduino-with-git-and-github&data=04%7C01%7C%7Cecbe22b049fd4e7ac46508d89aca811a%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637429541821265044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3lhkxJfSnrbpsqxJT%2FzLZPgqHOmAm%2F37P73c1dbKOhE%3D&reserved=0> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadafruit%2FAdafruit_CircuitPython_AS7341%2Fissues%2F1%23issuecomment-740014949&data=04%7C01%7C%7Cecbe22b049fd4e7ac46508d89aca811a%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637429541821274994%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6VZ%2Br6M0%2FpJU21p04W7CW3GiTFr2pzIeRWy3nzVSqjE%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACTK76XNWLNGVANUCYX2XG3STT44HANCNFSM4UQJJAQQ&data=04%7C01%7C%7Cecbe22b049fd4e7ac46508d89aca811a%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637429541821274994%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=q2ox0xI2fdAYQXxC1gf0kbrXRfgHZs5OO2tmnAaQSbI%3D&reserved=0>.

…

---------------------------------------------------------------------------------------------------------------------- Prifysgol y Flwyddyn ar gyfer Ansawdd y Dysgu a Phrofiad Myfyrwr University of the year for Teaching Quality and Student Experience (The Times and Sunday Times, Good University Guide 2021) Rydym yn croesawu gohebiaeth yn Gymraeg a Saesneg. Cewch ateb Cymraeg i bob gohebiaeth Gymraeg ac ateb Saesneg i bob gohebiaeth Saesneg. Ni fydd gohebu yn Gymraeg yn arwain at oedi. We welcome correspondence in Welsh and English. Correspondence received in Welsh will be answered in Welsh and correspondence in English will be answered in English. Corresponding in Welsh will not involve any delay.

[siddacious]

hi @DaveLangstaff let me know if you've got any questions about the process

[DaveLangstaff]

Hi, Sorry it's taking a while, emf of term business compounded by my Pi deciding to scribble on its sd card. Should be OK and good to go in a day Dave On 14 Dec 2020 6:22 p.m., siddacious <notifications@github.com> wrote: [RHYBUDD! E-BOST ALLANOL / CAUTION! EXTERNAL E-MAIL] hi @DaveLangstaff<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDaveLangstaff&data=04%7C01%7C%7C280b426ad19d43f995e008d8a05d447d%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637435669754921327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GrpZwgpdEjg6wtzUXek8odhxIQrcFYHLoX5aICtGsCU%3D&reserved=0> let me know if you've got any questions about the process — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadafruit%2FAdafruit_CircuitPython_AS7341%2Fissues%2F1%23issuecomment-744623033&data=04%7C01%7C%7C280b426ad19d43f995e008d8a05d447d%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637435669754931319%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WvjoSs9mIVqDuVcllPnajYJT5gSPZMfYLzNCrAehxjI%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACTK76TVYGPYLCDXR4DNMOLSUZJXVANCNFSM4UQJJAQQ&data=04%7C01%7C%7C280b426ad19d43f995e008d8a05d447d%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637435669754931319%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=B9CKllg3gJKCYoRZhS1TBy4dmXp1CzGCbyW27K%2FFX6k%3D&reserved=0>.

…

---------------------------------------------------------------------------------------------------------------------- Prifysgol y Flwyddyn ar gyfer Ansawdd y Dysgu a Phrofiad Myfyrwr University of the year for Teaching Quality and Student Experience (The Times and Sunday Times, Good University Guide 2021) Rydym yn croesawu gohebiaeth yn Gymraeg a Saesneg. Cewch ateb Cymraeg i bob gohebiaeth Gymraeg ac ateb Saesneg i bob gohebiaeth Saesneg. Ni fydd gohebu yn Gymraeg yn arwain at oedi. We welcome correspondence in Welsh and English. Correspondence received in Welsh will be answered in Welsh and correspondence in English will be answered in English. Corresponding in Welsh will not involve any delay.

[siddacious]

@DaveLangstaff No worries, take your time! We'll be here when you're ready.

Enjoy the holidays :)

[DaveLangstaff]

Hi, Happy New Year. I'm picking things up after the break and was wondering your opinion on the maximum current for the LED and how to approach this. The AS7341 itself allows for an LED current of up to 258mA, so theoretically, the code could use this as a maximum value. However the LED used on the Adafruit breakout board (EAHC2835WD6) has a stated maximum of 180mA, so the library probably shouldn't go above that. Over the break I hooked up a breakout board in a sealed box and recorded the sensor values for different currents up to 150mA (see attached PNG). As you can see from the plot, the LED output seems pretty linear up to 100mA but above this, there seems to be some current limitation. I've checked this with code running on both an Pi and also an Arduino, and got the same result, so it does seem a feature of the breakout board - probably due to the 7312 voltage convertor IC used. I'd be interested to hear your feelings on this and how this should be reflected in the library Regards Dave Langstaff From: siddacious <notifications@github.com> Sent: 28 December 2020 18:58 To: adafruit/Adafruit_CircuitPython_AS7341 <Adafruit_CircuitPython_AS7341@noreply.github.com> Cc: Dave Langstaff [dpl] <dpl@aber.ac.uk>; Mention <mention@noreply.github.com> Subject: Re: [adafruit/Adafruit_CircuitPython_AS7341] Setting LED current (#1) [RHYBUDD! E-BOST ALLANOL / CAUTION! EXTERNAL E-MAIL] @DaveLangstaff<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDaveLangstaff&data=04%7C01%7C%7Cece741895d2a4f2a902d08d8ab62720b%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637447786612287520%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9zp5O%2B%2FKEFgnIf06t2LqydBSoR%2Bj2s1WInanbWQKpFI%3D&reserved=0> No worries, take your time! We'll be here when you're ready. Enjoy the holidays :) - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadafruit%2FAdafruit_CircuitPython_AS7341%2Fissues%2F1%23issuecomment-751828949&data=04%7C01%7C%7Cece741895d2a4f2a902d08d8ab62720b%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637447786612287520%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=THJ02iqgdmgPhiMVWsYK%2FQApRBpFhMXmVUiEDB9ncyA%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACTK76VULRLJUO4YU62GOFDSXDIKBANCNFSM4UQJJAQQ&data=04%7C01%7C%7Cece741895d2a4f2a902d08d8ab62720b%7Cd47b090e3f5a4ca084d09f89d269f175%7C0%7C0%7C637447786612297513%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZI7FRUiAEIME0qHMQP3KGBqP%2FutYtUmah9QLI1VIvOE%3D&reserved=0>.

…

---------------------------------------------------------------------------------------------------------------------- Prifysgol y Flwyddyn ar gyfer Ansawdd y Dysgu a Phrofiad Myfyrwr University of the year for Teaching Quality and Student Experience (The Times and Sunday Times, Good University Guide 2021) Rydym yn croesawu gohebiaeth yn Gymraeg a Saesneg. Cewch ateb Cymraeg i bob gohebiaeth Gymraeg ac ateb Saesneg i bob gohebiaeth Saesneg. Ni fydd gohebu yn Gymraeg yn arwain at oedi. We welcome correspondence in Welsh and English. Correspondence received in Welsh will be answered in Welsh and correspondence in English will be answered in English. Corresponding in Welsh will not involve any delay.

[caternuson]

Closing. Fixed with #9.