Skip to content

Add UART support #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 4, 2020
Merged

Add UART support #14

merged 7 commits into from
May 4, 2020

Conversation

caternuson
Copy link
Contributor

For #8

BREAKING CHANGE

  • Adds UART support
  • Classes refactored into base and I2C/UART specific subs
  • Classes renamed to remove leading Adafruit_
  • Example updated

Tested with Itsy M4.

itsy_test

Adafruit CircuitPython 5.1.0 on 2020-04-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import as726x_simpletest


V: 
B: =
G: ========
Y: =====
O: ==============
R: ===

@caternuson caternuson requested a review from a team April 18, 2020 17:21
ladyada
ladyada approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test with hardware but lgtm!

@ladyada
Copy link
Member

ladyada commented Apr 18, 2020

(dont forget to update the guide too! :)

@FoamyGuy
Copy link
Contributor

I tested this successfully with an Itsy Bitsy M0 and the AS7262 breakout. It's working well as far as I can tell.

@kattni kattni merged commit 8df00d8 into adafruit:master May 4, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 5, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@ddcf3f0)
5aa8e96 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS726x to 2.0.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS726x#14 from caternuson/uart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caternuson @ladyada @FoamyGuy @kattni