Skip to content

add option to specify baudrate #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2022
Merged

add option to specify baudrate #25

merged 2 commits into from
Sep 28, 2022

Conversation

semininja
Copy link
Contributor

added argument to __init__ to allow users to set baudrate if desired

retains previous default if unspecified

added argument to `__init__` to allow users to set baudrate if desired

retains previous default if unspecified
@semininja
Copy link
Contributor Author

I don't know enough about how the CI checks work to be able to tell why black is somehow causing this to fail; it doesn't appear that the actual function was tested.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, thanks for the PR!

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to respond to your followup about black. If you run pre-commit, it should reformat things accordingly so it will pass if you submit the changes it makes. You can find information on using pre-commit here:

https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

@semininja
Copy link
Contributor Author

Unfortunately, I'm not able to run pre-commit successfully for some reason. Here's what appears to be the relevant chunk from the log:

      _ruamel_yaml.c:6:10: fatal error: Python.h: No such file or directory
          6 | #include "Python.h"
            |          ^~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> ruamel.yaml.clib

@semininja semininja requested a review from tekktrik September 28, 2022 02:04
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was an extra bit of whitespace causing the issue. Thanks!

@tekktrik tekktrik merged commit 78b03fa into adafruit:main Sep 28, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants