Skip to content

Add way for user to specify a min and max length of a tag #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

makeupsomething
Copy link

I have added a way for a user to specify the min and max length of a tag

@tristanbes
Copy link

Thanks for your contribution.

How did you find our fork ?

@makeupsomething
Copy link
Author

I am using it in a project for work and this min/max length thing was actually something necessary for us.

If you don't think you need it as a feature feel free close this PR 👍

@Kocal
Copy link

Kocal commented Mar 20, 2018

Thanks your for this contribution! 🎉 (so... we are not the only one to use this fork... 😮 🤣)

Your feature is very nice 👍
Can you add the props length into the documentation please?

Also, do you think it is possible to make the length configurable on the playground? That would be nice to have one or two <input type="number"> to configure min and max length.

Thanks 🙂

@Kocal
Copy link

Kocal commented Mar 21, 2018

Thanks @makeupsomething. 🎉

@Kocal Kocal merged commit fee433b into Yproximite:master Mar 21, 2018
@makeupsomething
Copy link
Author

@Kocal Thanks! My first opens source PR! 🎉

@tristanbes
Copy link

tristanbes commented Mar 21, 2018

Congratulations, I hope it's the first among many more !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants