Fix to strict rules and exclude pattern uses #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwulff
requested review from
igorwulff,
leonhelmus,
fredden,
rutgerrademaker,
Anve94,
DuckThom and
arnoudhgz
fredden
reviewed
Jun 6, 2024
igorwulff
approved these changes
Jun 6, 2024
* Fix Exclude pattern, the patterns did not include the dot of the extension allowing matching with the pathname (which for example in DDEV will match with `html` in `/var/www/html`) * Included more rules to exclude for (p)html and xml files. Indentation, line-length are very hard to fix consistently and prevents usage of component libraries (as for example with Hyvä)
elzekool
force-pushed
the
bugfix/fix-to-strict-rules-and-exclude-pattern-uses
branch
from
224ea9f to
cb0454b
Compare
|
Hi @fredden I tested and fixed your suggestion about the leading *. and removed it. |
|
@fredden @igorwulff I kind of agree with your point on the separate PR's especially from a library/package standpoint. But from an impact standpoint they are targeting the same issue, to get the issue fixed the first PR then needed to be merged (and tagged) before I could/can create the next PR while at the moment my project is having issues with the package and other teams are just making work-a-rounds to skip checks which they should not. |
|
Lets wait until tomorrow afternoon, and give some time for the others to have checked this PR. If there are no blockers we can merge it. |
arnoudhgz
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Exclude pattern, the patterns did not include the dot of the extension allowing matching with the pathname (which for example in DDEV will match with
htmlin/var/www/html)Included more rules to exclude for (p)html and xml files. Indentation, line-length are very hard to fix consistently and prevents usage of component libraries (as for example with Hyvä)