Skip to content

fix: top-level alias type comments parse #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2020
Merged

fix: top-level alias type comments parse #395

merged 2 commits into from
Dec 23, 2020

Conversation

ExcitedSpider
Copy link
Contributor

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

As discussed in #394 , parse comment for top-level type.

@ExcitedSpider ExcitedSpider changed the title fix: alias type comments parse fix: top-level alias type comments parse Dec 22, 2020
@ExcitedSpider ExcitedSpider mentioned this pull request Dec 22, 2020
Closed
@domoritz
Copy link
Collaborator

Thank you for the pull request. Can you please fix the test cases? You can either correct the specs if that's needed or fix the code.

@ExcitedSpider
Copy link
Contributor Author

OK, I'll do it.

@ExcitedSpider
Copy link
Contributor Author

Hi, I've corrected the test case by adding the parsed comment for type alias.

@domoritz
Copy link
Collaborator

fixes #394

@domoritz domoritz merged commit 32e18a4 into YousefED:master Dec 23, 2020
@marneborn marneborn mentioned this pull request Feb 23, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExcitedSpider @domoritz