Skip to content

fix: do not compute definition of ignored fields (#299) #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix: do not compute definition of ignored fields (#299) #390

merged 2 commits into from
Nov 30, 2020

Conversation

loopingz
Copy link
Contributor

@loopingz loopingz commented Nov 30, 2020 •
edited
Loading

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

domoritz
domoritz reviewed Nov 30, 2020
View reviewed changes
@domoritz domoritz merged commit 9b1ee8d into YousefED:master Nov 30, 2020
@domoritz domoritz mentioned this pull request Nov 30, 2020
Closed
@loopingz
Copy link
Contributor Author

@domoritz thank you very much for the quick merge!

@domoritz
Copy link
Collaborator

Thank you for the pull request. I made a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loopingz @domoritz