Servlet import fix #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to run a test without output buffering.
|
Thanks a lot, will look into that later. Note that monitoring servlet files is not absolutely necessary - if you disable servlet caching in Application.config, which is the default in development mode, they are always loaded new, which has the same effect. However, if you want to simulate production with caching, and also monitor library files for changes, you need monitoring. In Webware for Python 2 this was the task of the "ImportSpy", which has been replaced by "hupper" in Webware for Python 3. |
|
This will be shipped with 3.0.0a1. Thanks again, particularly for adding the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my legacy apps does some introspection and relies on servlets showing up in sys.modules. This code failed. In investigating, I discovered a subtle issues with the servlet import code. This PR fixes the issue and includes new tests.
Initially I found that servlets modules were not being put into sys.modules due to a simple typo. After fixing that, I found that sys.modules was being updated with the key 'MyContext.MyServlet' (correct), but the module name as visible from within the servlet (e.g. name) was simply 'MyServlet', not the fully qualified module name 'MyContext.Servlet', so there was an inconsistency.
I also added a test to make sure ImportManager monitors the import servlet file for changes. It was working fine beforehand, but I wanted to test and make sure I didn't break anything with my changes.