Skip to content

Drop running CI jobs on macos-m1 custom runner #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

Drop running CI jobs on macos-m1 custom runner #578

merged 1 commit into from
Aug 1, 2024

Conversation

Gedochao
Copy link

@Gedochao Gedochao commented Aug 1, 2024

@Gedochao Gedochao requested a review from tgodzik August 1, 2024 12:26
@Gedochao Gedochao marked this pull request as ready for review August 1, 2024 12:26
@Gedochao
Copy link
Author

Gedochao commented Aug 1, 2024

@tgodzik need to change the required job from test (macOS-m1, temurin:17) to test (macOS-13, temurin:17), as the CI is expecting a check that will never come.

@tgodzik tgodzik merged commit 937c63d into VirtusLab:main Aug 1, 2024
4 checks passed
@Gedochao Gedochao deleted the maintenance/migrate-macos-m1-jobs branch August 1, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @tgodzik