Skip to content

chore: Introduction to Arrays #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 7, 2021
Merged

chore: Introduction to Arrays #91

merged 11 commits into from
Oct 7, 2021

Conversation

shoebxsiddiqui
Copy link
Contributor

@shoebxsiddiqui shoebxsiddiqui commented Oct 6, 2021 •
edited
Loading

Fixes #1

Short description of what this resolves:

What Changes proposed in this pull request:

-Added images
-Added content in Arrays.md

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added code examples, test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@shoebxsiddiqui
Copy link
Contributor Author

@Utkarsh1504 Done with the PR pls review and suggest changes if it needs.

Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 reviewed Oct 7, 2021
View reviewed changes
Utkarsh1504
Utkarsh1504 requested changes Oct 7, 2021
View reviewed changes
Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the suggested syntax part, concept-wise it is all great. 👍🏻 👍🏻

shoebxsiddiqui and others added 9 commits October 7, 2021 23:32
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
b0e87de 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
4ef58c0 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
392acb5 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
7b902aa 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
c499d64 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
3fc09fb 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
14d93f3 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
d9471dc 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui @Utkarsh1504
Update lessons/arrays.md
4363b20 
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@shoebxsiddiqui
Copy link
Contributor Author

Done sir @Utkarsh1504

@Utkarsh1504 Utkarsh1504 changed the title Shoebxsiddiqui Arrays chore: Introduction to Arrays Oct 7, 2021
Utkarsh1504
Utkarsh1504 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine @shoebxsiddiqui.

@Utkarsh1504
Copy link
Owner

Thank you for your contribution @shoebxsiddiqui 🎈🎉🎉. and please don't call me as sir 😄 , Great work by the way 👍🏻.
One thing I want to suggest to you is that in future contributions please make sure the content you add doesn't exactly copy from other sites. 🎉🎈

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest and removed requested-change labels Oct 7, 2021
@Utkarsh1504 Utkarsh1504 added the ✅ Ready for merge approved pull request label Oct 7, 2021
@shoebxsiddiqui
Copy link
Contributor Author

Thanks for your suggestion, I will take care from next time.

@Utkarsh1504 Utkarsh1504 merged commit fe56e81 into Utkarsh1504:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Utkarsh1504 Utkarsh1504 Utkarsh1504 approved these changes

Assignees
No one assigned
Labels
approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new lesson: Introduction to Arrays
2 participants
@shoebxsiddiqui @Utkarsh1504