Skip to content

Added upstream command #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

tanishagupta1
Copy link
Contributor

Fixes #61

Short description of what this resolves:

What Changes proposed in this pull request:

  • Added command to set upstream in the local repository in Readme.md

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@tanishagupta1
Copy link
Contributor Author

May you please add this pull request under hacktoberfest if find relevant. Thank You, Do let me know about any other required changes

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request labels Oct 3, 2021
@Utkarsh1504
Copy link
Owner

Thank you!

@Utkarsh1504
Copy link
Owner

@tanishagupta1 why you pushed these commits in this PR, please undo these changes which you have made later, and please make a new PR then push those commits.
I will suggest to you make a new branch otherwise you may face merging conflicts issues, I have given step by step instructions on how to use version control, please follow that.

@tanishagupta1
Copy link
Contributor Author

Yes I completely got the point sorry for the inconvenience, I'll fix it

@tanishagupta1
Copy link
Contributor Author

Can you pls guide me as to if I should fetch and merge with the upstream branch and again make the commit or as I reverted the commit, it doesn't seem to resolve the issue

@Utkarsh1504
Copy link
Owner

Ok, you just have reverted both the commits:

  1. Add upstream command and
  2. Add code in java

Now just make a commit for the adding upstream command again and That's it.

@tanishagupta1
Copy link
Contributor Author

reverted to added upstream commit hope the issue is resolved now

@Utkarsh1504
Copy link
Owner

@tanishagupta1 yes you did it! Thank you!

@Utkarsh1504 Utkarsh1504 merged commit f079631 into Utkarsh1504:main Oct 4, 2021
@tanishagupta1
Copy link
Contributor Author

Thank you for the help!

@Utkarsh1504
Copy link
Owner

Now In the future contribution please make a new branch and then contribute in that only, don't do contribution in the main branch.

@tanishagupta1
Copy link
Contributor Author

yes definitely! taking the learnings with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggested improvement Readme.md
2 participants