Skip to content

Markdown file added #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Conversation

preeti-14-7
Copy link
Contributor

Fixes #7

Short description of what this resolves:

What Changes proposed in this pull request:

  • I have added the detail explanation of ArrayList in java.
  • I have added some code snippet also.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added code examples, test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
This is a documentation of DSA in Java

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Some small tweaks and your PR is ready for merge.
The content looks really great!

Comment on lines 8 to 9
## ArrayList in java
<hr>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## ArrayList in java
<hr>

remove these two lines, lesson heading will be there on the site by default

- Change elements
- Remove elements

## Add Elements :
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Add Elements :
### Add Elements:

make the heading h3

}
}
```
## Output
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Output
### Output:

}

```
## Output
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Output
### Output:

}
}
```
## Output
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Output
### Output:

}
}
```
## Output
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Output
### Output:

ArrayList<String> languages = new ArrayList<>();

// add() method without the index parameter
playerName.add("Virat");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

playerName is not defined??


class Main {
public static void main(String[] args) {
ArrayList<String> animals = new ArrayList<>();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define playerName instead of animals

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do these changes

Added the changes
@preeti-14-7
Copy link
Contributor Author

Check it again.

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request and removed requested-change labels Oct 3, 2021
@Utkarsh1504
Copy link
Owner

Thank you for your work!🎉🎉🎈

@Utkarsh1504 Utkarsh1504 merged commit 3f20f67 into Utkarsh1504:main Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new lesson: ArrayList In Java
2 participants