Skip to content

UtAssembleModel refactor #812 #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 20, 2022
Merged

Conversation

sergeypospelov
Copy link
Member

@sergeypospelov sergeypospelov commented Sep 19, 2022

Description

Refactored API:

  • Removed useless UtExecutableCallModel::returnValue. It was providing duplicate information accordingly to our use cases. Rewrote these use cases, with relying on another API.
  • Changed UtAssembleModel::instantiationChain to UtAssembleModel::instantiationCall
  • Made the primary constructor of UtAssembleModel private due to its unclear syntax with mutable lists. Added a more understandable (in my point of view) constructor. Rewrote all the usages of the previous one.
  • Updated in-code documentation.
  • Fixed an error in the AssembleModelGenerator and turned on a test, which checks this error.

Fixes #812

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Automated Testing

Turned on org.utbot.examples.codegen.deepequals.ClassWithCrossReferenceRelationshipTest

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@sergeypospelov sergeypospelov force-pushed the sergey/assemble_model_refactor branch from c3c44d6 to 7850497 Compare September 19, 2022 16:38
@sergeypospelov sergeypospelov force-pushed the sergey/assemble_model_refactor branch 2 times, most recently from c4786fc to d59bef1 Compare September 19, 2022 21:42
@sergeypospelov sergeypospelov force-pushed the sergey/assemble_model_refactor branch from d59bef1 to 91d5a4d Compare September 20, 2022 06:43
Copy link
Collaborator

@SBOne-Kenobi SBOne-Kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergeypospelov sergeypospelov force-pushed the sergey/assemble_model_refactor branch from 91d5a4d to 6df189c Compare September 20, 2022 06:47
@sergeypospelov sergeypospelov enabled auto-merge (squash) September 20, 2022 06:48
@sergeypospelov sergeypospelov changed the title UtAssembleModel refactor #812 UtAssembleModel refactor #812 Sep 20, 2022
@sergeypospelov sergeypospelov enabled auto-merge (squash) September 20, 2022 07:35
@sergeypospelov sergeypospelov force-pushed the sergey/assemble_model_refactor branch from 6df189c to e46d848 Compare September 20, 2022 08:29
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergeypospelov sergeypospelov merged commit 14aef84 into main Sep 20, 2022
@sergeypospelov sergeypospelov deleted the sergey/assemble_model_refactor branch September 20, 2022 09:37
@denis-fokin denis-fokin added this to the Release preparation milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflow when constructing an object with Assemble Model
4 participants