-
Notifications
You must be signed in to change notification settings - Fork 46
Reduce concurrent jobs number for projects #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce concurrent jobs number for projects #945
Conversation
steps: | ||
- name: Print environment variables | ||
run: printenv | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra spaces please
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces...
runs-on: ubuntu-20.04 | ||
container: unittestbot/java-env:java11-zulu-jdk-gradle7.4.2-kotlinc1.7.0 | ||
steps: | ||
- name: Print environment variables | ||
run: printenv | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces
@@ -79,14 +79,14 @@ jobs: | |||
chmod +x ./scripts/project/monitoring.sh | |||
./scripts/project/monitoring.sh ${{ secrets.PUSHGATEWAY_HOSTNAME }} ${{ secrets.PUSHGATEWAY_USER }} ${{ secrets.PUSHGATEWAY_PASSWORD }} | |||
- name: Run tests | |||
run: | | |||
gradle --no-daemon :utbot-framework-test:test ${{ matrix.project.TESTS_TO_RUN }} | |||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces
@@ -128,6 +190,9 @@ jobs: | |||
git config --global --add safe.directory ${GITHUB_WORKSPACE} | |||
git fetch | |||
git checkout ${{ github.event.inputs.commit_sha }} | |||
- uses: actions/checkout@v3 | |||
with: | |||
ref: ${{ env.COMMIT_SHA }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work and should be removed. Maybe your branch has old main
revision
needs: prepare-tests-matrix | ||
# Using matrices let create multiple jobs runs based on the combinations of the variables from matrices. | ||
FRAMEWORK_TESTS=$(echo $(cat .github/workflows/framework-tests-matrix.json)) | ||
COMBINED_PROJECTS=$(echo $(cat .github/workflows/combined-projects-matrix.json)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe echo
in this two lines doesn't make sense
git checkout ${{ github.event.inputs.commit_sha }} | ||
- uses: actions/checkout@v3 | ||
with: | ||
ref: ${{ env.COMMIT_SHA }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to fix last bug.
LGTM
Description
The changes reduce number of concurrent jobs used in building and running tests for UTBot by 4. It combines some of jobs together, e.g. utbot-summary with utbot-summary-tests, utbot-api with utbot-framework-api etc.
Fixes #814
Type of Change
Infrastructure changes.
How Has This Been Tested?
Automated Testing
It was tested on branch.
Manual Scenario
Not applicable.
Checklist (remove irrelevant options):
Not applicable.