Skip to content

Reduce concurrent jobs number for projects #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Sep 20, 2022

Conversation

viktoriia-fomina
Copy link
Member

Description

The changes reduce number of concurrent jobs used in building and running tests for UTBot by 4. It combines some of jobs together, e.g. utbot-summary with utbot-summary-tests, utbot-api with utbot-framework-api etc.

Fixes #814

Type of Change

Infrastructure changes.

How Has This Been Tested?

Automated Testing

It was tested on branch.

Manual Scenario

Not applicable.

Checklist (remove irrelevant options):

Not applicable.

@viktoriia-fomina viktoriia-fomina marked this pull request as ready for review September 16, 2022 13:51
steps:
- name: Print environment variables
run: printenv

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra spaces please

- name: Checkout repository
uses: actions/checkout@v3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces...

runs-on: ubuntu-20.04
container: unittestbot/java-env:java11-zulu-jdk-gradle7.4.2-kotlinc1.7.0
steps:
- name: Print environment variables
run: printenv

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces

@@ -79,14 +79,14 @@ jobs:
chmod +x ./scripts/project/monitoring.sh
./scripts/project/monitoring.sh ${{ secrets.PUSHGATEWAY_HOSTNAME }} ${{ secrets.PUSHGATEWAY_USER }} ${{ secrets.PUSHGATEWAY_PASSWORD }}
- name: Run tests
run: |
gradle --no-daemon :utbot-framework-test:test ${{ matrix.project.TESTS_TO_RUN }}
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces

@@ -128,6 +190,9 @@ jobs:
git config --global --add safe.directory ${GITHUB_WORKSPACE}
git fetch
git checkout ${{ github.event.inputs.commit_sha }}
- uses: actions/checkout@v3
with:
ref: ${{ env.COMMIT_SHA }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work and should be removed. Maybe your branch has old main revision

needs: prepare-tests-matrix
# Using matrices let create multiple jobs runs based on the combinations of the variables from matrices.
FRAMEWORK_TESTS=$(echo $(cat .github/workflows/framework-tests-matrix.json))
COMBINED_PROJECTS=$(echo $(cat .github/workflows/combined-projects-matrix.json))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe echo in this two lines doesn't make sense

@viktoriia-fomina viktoriia-fomina changed the title Reduce concurrent jobs number for projects #814: Reduce concurrent jobs number for projects (#33) Sep 19, 2022
@viktoriia-fomina viktoriia-fomina changed the title #814: Reduce concurrent jobs number for projects (#33) Reduce concurrent jobs number for projects Sep 19, 2022
git checkout ${{ github.event.inputs.commit_sha }}
- uses: actions/checkout@v3
with:
ref: ${{ env.COMMIT_SHA }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove please

Copy link
Member

@bissquit bissquit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to fix last bug.
LGTM

@viktoriia-fomina viktoriia-fomina merged commit aa8f7a9 into main Sep 20, 2022
@viktoriia-fomina viktoriia-fomina deleted the victoria/reduce-concurrent-jobs-number branch September 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce concurrent jobs number for projects
2 participants