Skip to content

Added simplification/rewriting for assumptions #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

Damtev
Copy link
Member

@Damtev Damtev commented Sep 16, 2022

Description

Added simplification and rewriting for assumption constraints.

Fixes #630.

Type of Change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

org.utbot.examples.stream.BaseStreamExampleTest#testDistinctExample

Manual Scenario

Example from the issue:

public class ApplyForAllExample<T> {
    public int getGenericCollectionArgumentSize(@NotNull Collection<T> arg) {
        return arg.size();
    }
}

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • All tests pass locally with my changes

@Damtev Damtev requested review from dtim and CaelmBleidd September 16, 2022 08:33
@Damtev Damtev force-pushed the damtev/assumptions_simplification_support branch from d61b7a9 to a4b5202 Compare September 16, 2022 10:00
CaelmBleidd
CaelmBleidd previously approved these changes Sep 16, 2022
@CaelmBleidd CaelmBleidd dismissed their stale review September 16, 2022 10:41

Discussed, seems like we have contradictions between our view on the changes

@Damtev Damtev requested a review from CaelmBleidd September 16, 2022 11:42
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to fix the issue (at least on Collection<T>.size() example).

@Damtev Damtev enabled auto-merge (squash) September 16, 2022 12:00
@Damtev Damtev disabled auto-merge September 16, 2022 12:00
@Damtev Damtev enabled auto-merge (squash) September 16, 2022 12:18
@Damtev Damtev merged commit fcc4d81 into main Sep 16, 2022
@Damtev Damtev deleted the damtev/assumptions_simplification_support branch September 16, 2022 12:47
@SBOne-Kenobi
Copy link
Collaborator

Fixed #298

@denis-fokin denis-fokin added this to the Release preparation milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException in Z3Translator
5 participants