Get static field concretly #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBOne-Kenobi
force-pushed
the
sbone/static_field_get_concretly
branch
from
f52c08b to
477b12e
Compare
SBOne-Kenobi
force-pushed
the
sbone/static_field_get_concretly
branch
from
477b12e to
439ff5a
Compare
sergeypospelov
approved these changes
Sep 13, 2022
| @@ -24,6 +25,8 @@ interface Instrumentation<out TInvocationInstrumentation> : ClassFileTransformer | |||
| parameters: Any? = null | |||
| ): TInvocationInstrumentation | |||
|
|
|||
| fun getStaticField(fieldId: FieldId): Result<*> | |||
There was a problem hiding this comment.
Why do we need it in a base class?
There was a problem hiding this comment.
Discussed. We will take a look at it later.
SBOne-Kenobi
force-pushed
the
sbone/static_field_get_concretly
branch
from
439ff5a to
24d8fba
Compare
SBOne-Kenobi
force-pushed
the
sbone/static_field_get_concretly
branch
from
24d8fba to
8cf391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepare to replace reflection with concrete executor for getting static field value.
Fixes #903
Type of Change
Checklist: