Skip to content

Update Soot and choose an analyzable JRE #373 #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

sergeypospelov
Copy link
Member

@sergeypospelov sergeypospelov commented Sep 9, 2022

Description

  • Synced up our Soot-fork with the main Soot branch.
  • Patched Soot to add the ability to choose an analyzable JDK. See this: Choose analyzable JRE soot#4
  • Reverted an internal Soot fix, because it had been producing unnecessary casts and our tests had failed.
  • Added jdkInfo field in the TestCaseGenerator for providing an analyzable JDK.
  • Added tests for checking the Soot's behavior on different JDKs, but they are disabled now, as our runner doesn't provide different JDKs. See Provide a build pipeline with different available JDKs #891.

Also found an internal Soot bug which affects us too: soot-oss/soot#1360.

Please note, that Soot slightly changed public API: stmt.rightBox.value to stmt.rightOp

Fixes #373

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated Testing

Added new tests, but they are disabled right now. Other unit-tests successfully pass.

Manual Scenario

To reproduce section from #373 passes.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@sergeypospelov sergeypospelov changed the title Update Soot and choose JRE Update Soot and choose an anlyzable JRE #373 Sep 13, 2022
Copy link
Collaborator

@SBOne-Kenobi SBOne-Kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for tests ;)

@sergeypospelov sergeypospelov changed the title Update Soot and choose an anlyzable JRE #373 Update Soot and choose an analyzable JRE #373 Sep 13, 2022
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergeypospelov sergeypospelov merged commit dc6b0ab into main Sep 14, 2022
@sergeypospelov sergeypospelov deleted the sergey/choose_soot_jdk branch September 14, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI with JDK 17 throws Unsupported class file major version 61
3 participants