Skip to content

Java 8 RDgen fix #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Java 8 RDgen fix #824

merged 1 commit into from
Aug 31, 2022

Conversation

Domonion
Copy link
Collaborator

@Domonion Domonion commented Aug 30, 2022

Description

After rdgen merge UTBot ceased to work with jvm 8 projects. Fixing it by returning some java 8 process id API, but reworking it to be compatible with jvm 9+

Type of Change

  • Minor bug fix (non-breaking small changes)

Automated Testing

All tests should work

Manual Scenario

Create java 8 project, test anything with plugin - test should be generated

  • All tests pass locally with my changes

@Domonion Domonion force-pushed the kononov-instrumentation-rdgen-fi-java8 branch from 68c8a46 to 39bde50 Compare August 30, 2022 15:01
@Domonion Domonion requested a review from Markoutte August 30, 2022 15:02
@Domonion Domonion force-pushed the kononov-instrumentation-rdgen-fi-java8 branch from 39bde50 to 1301d02 Compare August 30, 2022 15:06
Copy link
Collaborator

@Markoutte Markoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Domonion Domonion force-pushed the kononov-instrumentation-rdgen-fi-java8 branch from 1301d02 to 43fc5fb Compare August 31, 2022 07:43
@Domonion Domonion merged commit 248c196 into main Aug 31, 2022
@Domonion Domonion deleted the kononov-instrumentation-rdgen-fi-java8 branch August 31, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants