Skip to content

Minor refactoring in SimpleCommentBuildr and CustomJavaDocCommentBuilder #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Minor refactoring in SimpleCommentBuildr and CustomJavaDocCommentBuilder #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac358c8
Minor refactoring in SimpleCommentBuildr and CustomJavaDocCommentBuilder
onewhl Aug 24, 2022
8a22643
Minor review fix
onewhl Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions utbot-summary/src/main/kotlin/org/utbot/summary/comment/CustomJavaDocCommentBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,11 @@ class CustomJavaDocCommentBuilder(

// builds Throws exception section
val thrownException = traceTag.result.exceptionOrNull()
val exceptionThrow: String? = if (thrownException == null) {
traceTag.result.exceptionOrNull()?.let { it::class.qualifiedName }
} else {
if (thrownException != null) {
val exceptionName = thrownException.javaClass.name
val reason = findExceptionReason(currentMethod, thrownException)
"{@link $exceptionName} $reason"
}

if (exceptionThrow != null) {
customJavaDocComment.throwsException = exceptionThrow
customJavaDocComment.throwsException = "{@link $exceptionName} $reason"
}

// builds Iterates section
Expand Down
9 changes: 3 additions & 6 deletions utbot-summary/src/main/kotlin/org/utbot/summary/comment/SimpleCommentBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,9 @@ open class SimpleCommentBuilder(
root: SimpleSentenceBlock,
currentMethod: SootMethod
) {
val thrownException = traceTag.result.exceptionOrNull()
if (thrownException == null) {
root.exceptionThrow = traceTag.result.exceptionOrNull()?.let { it::class.qualifiedName }
} else {
val exceptionName = thrownException.javaClass.simpleName
val reason = findExceptionReason(currentMethod, thrownException)
traceTag.result.exceptionOrNull()?.let {
val exceptionName = it.javaClass.simpleName
val reason = findExceptionReason(currentMethod, it)
root.exceptionThrow = "$exceptionName $reason"
}
}
Expand Down