Skip to content

passing all secrets into reusable workflow #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

bissquit
Copy link
Member

@bissquit bissquit commented Aug 23, 2022

Description

Checking why metrics are not pushed when workflow_call is used.

Fixes #781

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

Not applicable

Manual Scenario

Metrics of the workflow run will be accessible in our monitoring system

Checklist (remove irrelevant options):

  • Test will be run automatically after creating a PR. Wait for test has been done
  • Check metrics at monitoring system

@bissquit bissquit requested a review from denis-fokin August 23, 2022 13:27
@bissquit bissquit self-assigned this Aug 23, 2022
Copy link
Member

@viktoriia-fomina viktoriia-fomina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bissquit bissquit linked an issue Aug 24, 2022 that may be closed by this pull request
@bissquit bissquit merged commit f578c21 into main Aug 24, 2022
@bissquit bissquit deleted the egor-vasiliev/fix-workflow-08-23 branch August 24, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Monitoring metrics are not sent if workflow_call is used
3 participants