Rd-gen #748
Merged
Rd-gen #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domonion
force-pushed
the
kononov-instrumentation-rdgen
branch
from
a3b2388 to
04413f1
Compare
korifey
reviewed
Aug 22, 2022
SBOne-Kenobi
requested changes
Aug 23, 2022
There was a problem hiding this comment.
Formatting questions
I hope that you will write one or several docs or at least a brief description in the PR about:
- How communication between child and main processes works
- How to support new commands, some requirements and tips for this
- A brief description about ChildProcess structure and workflow
- A brief description about rdgen builds
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/util/KryoHelper.kt
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/util/KryoHelper.kt
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcessRunner.kt
Outdated
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcess.kt
Outdated
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcess.kt
Outdated
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcess.kt
Outdated
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt
Show resolved
Hide resolved
Domonion
force-pushed
the
kononov-instrumentation-rdgen
branch
3 times, most recently
from
6dfbc94 to
c686178
Compare
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcess.kt
Outdated
Show resolved
Hide resolved
Domonion
force-pushed
the
kononov-instrumentation-rdgen
branch
3 times, most recently
from
0565a73 to
0407bf5
Compare
SBOne-Kenobi
approved these changes
Aug 29, 2022
1. switched from Protocol.Command to rd generated model 2. added utbot-rd project featuring LifetimedProcess, ProcessWithRdServer and minor rd-related utility classes 3. Switched from message-driven ConcreteExecutor to callback rd model, featuring UtInstrumentationProcess
Domonion
force-pushed
the
kononov-instrumentation-rdgen
branch
from
3519b4a to
05a40d9
Compare
rebase fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved child process communication to RD. Added ability to track process through JetBrains.Lifetimes. Refactored ConcreteExecutor to support JetBrains.Lifetimes and RD
Type of Change
Please delete options that are not relevant.
Automated Testing
org.utbot.examples.collections.ListsTest
org.utbot.examples.collections.MapsTest
org.utbot.external.api.UtBotJavaApi
org.utbot.examples.exceptions.JvmCrashExamplesTest
All tests should work