corrected ClassId.isAccessibleFrom behavior on arrays #743 #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ClassId.isAccessibleFrom
didn't work correctly on arrays (sometimes returned false when it should have returned true), which lead to unnecessary usage of refelction and bugs in generated tests.Now this method returns true on array iff contained elements' class is accessible.
Fixes #743
Type of Change
How Has This Been Tested?
Manual Scenario
Launch plugin on example from #743 -- tests are generated without reflections.
Checklist (remove irrelevant options):
This is the author self-check list