Add unit tests for builders #543 #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandelpie
requested changes
Aug 17, 2022
There was a problem hiding this comment.
It's a good question, should we test private methods or not, I suggest to use reflection or change the visibility of a few methods to the package-private or internal and test private methods without mockito but after moving from Soot to JCDB
If you wish, you could play with changing visibility at this PR for 1-2 method for the SimpleNameBuilder
Please add a few tests if possible, fix the broken test and fix the issue with the mockito verision
| } | ||
|
|
||
| @Test | ||
| fun `throws throwable if execution result is null`() { |
There was a problem hiding this comment.
This test fails on my side with
expected: <<pre>
Test throws Throwable
</pre>> but was: < >
There was a problem hiding this comment.
i didn't expect these two builders have different behavior, but now we know. I fixed test
utbot-summary/src/test/kotlin/org/utbot/summary/comment/SimpleClusterCommentBuilderTest.kt
Show resolved
Hide resolved
utbot-summary/src/test/kotlin/org/utbot/summary/comment/SimpleCommentBuilderTest.kt
Show resolved
Hide resolved
|
@onewhl LGTM for me |
amandelpie
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added unit tests for SimpleNameBuilder, SimpleCommentBuilder, SimpleClusterCommentBuilder.
Unfortunately, most of the methods are private and kotlin properties not always could be mocked, so the number of tests is small.
Fixes #543
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
Run tests in PR.
Checklist (remove irrelevant options):
This is the author self-check list