Improve exception rendering in parametrized tests #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenHD
approved these changes
Aug 9, 2022
EgorkaKulikov
force-pushed
the
egor/pseudo_exception_var_name
branch
from
b12a3d9 to
72bb265
Compare
denis-fokin
pushed a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parametrized tests may contain reflective call in it's body or not.
If we do not have them, we should just catch
Throwableand verify that it's type has one type with the expected one.Otherwise we should catch
InvocationTargetExceptionand verify that it'stargetExceptionhas one type with the expected one.We should also wrap with
try/catchblock only the method call with the related assert, not all statements before too.Also fixes # (641)
Type of Change
How Has This Been Tested?
Automated Testing
utbot-samples pipeline passing is enough
Manual Scenario
Several typical scenarios for parametrized tests including tests with expected exceptions.