Fix empty true branch & correct generic execution selection logic in parametrized test generation #683 #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofurihafe
force-pushed
the
andrey-t/generic-execution
branch
2 times, most recently
from
8697bd1 to
8ff2ce6
Compare
sofurihafe
changed the title
sofurihafe
changed the title
sofurihafe
force-pushed
the
andrey-t/generic-execution
branch
from
123f8b9 to
7388c38
Compare
sofurihafe
force-pushed
the
andrey-t/generic-execution
branch
from
7388c38 to
42290f8
Compare
EgorkaKulikov
approved these changes
Aug 8, 2022
sofurihafe
force-pushed
the
andrey-t/generic-execution
branch
from
42290f8 to
87393f9
Compare
sofurihafe
force-pushed
the
andrey-t/generic-execution
branch
from
87393f9 to
62a51bd
Compare
denis-fokin
pushed a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with empty true branch body in parametrized test generation.
Also, the logic of selecting
generic executionwas corrected a little. Now, if there are no successful executions with non-null result, instead of selecting the first random one, we select the first successful execution with null result.Fixes # (683)
Type of Change
How Has This Been Tested?
Automated Testing
Run utbot samples with enabled parametrized test generation.
Manual Scenario
Run
testMockInterfaceWithoutImplementorstest. Verify that if-statement true branch contains an assertion.