CgMethodConstructor refactoring #677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volivan239
changed the base branch from
volivan239/improve_test_naming_for_nested_classes
to
main
volivan239
changed the base branch from
main
to
volivan239/improve_test_naming_for_nested_classes
volivan239
changed the title
volivan239
force-pushed
the
volivan239/method_constructor_refactoring
branch
from
537821d to
424f4c3
Compare
ArsenHD
reviewed
Aug 9, 2022
| @@ -1317,7 +1310,7 @@ internal class CgMethodConstructor(val context: CgContext) : CgContextOwner by c | |||
| return withDataProviderScope { | |||
| dataProviderMethod(dataProviderMethodName) { | |||
| val argListLength = testSet.executions.size | |||
| val argListVariable = createArgList(argListLength) | |||
| val argListVariable = testFrameworkManager.createArgList(argListLength, "argList") | |||
There was a problem hiding this comment.
I think we should not pass "argList" as an argument. Just use "argList" inside of createArgList() method like it was done before.
| @@ -221,6 +262,25 @@ internal fun CgContextOwner.typeCast( | |||
| return CgTypeCast(targetType, expression, isSafetyCast) | |||
| } | |||
|
|
|||
| // TODO: Doesn't it work for any array? | |||
| @@ -408,6 +480,28 @@ internal class Junit5Manager(context: CgContext) : TestFrameworkManager(context) | |||
| +assertions[assertThrows](exception.toExceptionClass(), lambda) | |||
| } | |||
|
|
|||
| override fun createDataProviderAnnotations(dataProviderMethodName: String?) = mutableListOf<CgAnnotation>() | |||
There was a problem hiding this comment.
Minor: add a blank line after this method
| mutableListOf( | ||
| statementConstructor.annotation( | ||
| testFramework.methodSourceAnnotationId, | ||
| listOf("name" to CgLiteral(stringClassId, dataProviderMethodName)) |
There was a problem hiding this comment.
Instead of CgLiteral(stringClassId, dataProviderMethodName you can write stringLiteral(dataProviderMethodName).
stringLiteral() is a function made to write such code more briefly. There are also booleanLiteral(), intLiteral(), etc.
|
Thanks for review! Fixed, changes from this PR will be cherry-picked in #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Substitute this text with a concise description of the proposed change. Emphasize, why particular solution was chosen.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
Specify tests that help to verify the change automatically.
Example: org.utbot.examples.algorithms.BinarySearchTest
Manual Scenario
Please, provide several scenarios that you went through to verify that the change worked as expected.
Checklist (remove irrelevant options):
This is the author self-check list