Skip to content

Optimize CLI image building #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

viktoriia-fomina
Copy link
Member

@viktoriia-fomina viktoriia-fomina commented Aug 4, 2022

Description

CLI: publish image is not a separate workflow anymore. This is a step in UTBot Java: build and run tests workflow triggered only on push to the main branch.

Fixes #648

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Automated Testing

Not applicable.

Manual Scenario

It was tested on fork.

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@viktoriia-fomina viktoriia-fomina marked this pull request as ready for review August 4, 2022 15:25
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Unit Test Results

1 815 tests   1 748 ✔️  1h 56m 29s ⏱️
   210 suites       67 💤
   210 files           0

Results for commit 812169e.

Copy link
Member

@bissquit bissquit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be great if you could clarify the points above

- name: Set timezone
uses: szenius/set-timezone@v1.0
with:
timezoneLinux: "Europe/Moscow"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need time zone here? And why is it set to Moscow?


RUN curl -H "Authorization: Bearer ${ACCESS_TOKEN}" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile looks much better

- uses: gradle/gradle-build-action@v2
with:
gradle-version: 6.8

- name: Set project version
run: echo "VERSION="$(date +%Y).$(date +%-m)"" >> $GITHUB_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many double quotes look ambiguous

- name: Move cache
run: |
rm -rf /tmp/.buildx-cache
mv /tmp/.buildx-cache-new /tmp/.buildx-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the cache matter when we run on clean runner each time?

@viktoriia-fomina viktoriia-fomina deleted the victoria/java-cli-image-build-update branch August 11, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize CLI image building
2 participants