Generate parametrized test for methods without force mocking in Uber and sample tests #591 #596 #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 28, 2022
Closed
nikitavlaev
approved these changes
Jul 29, 2022
EgorkaKulikov
approved these changes
Jul 29, 2022
EgorkaKulikov
deleted the
andrey-t/parametrization-in-samples-and-uber-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, we didn't generate any tests for a whole test class if there were force mocking and parametrized test generation mode in one of the methods.
Now, we just exclude methods with force mocking and parametrized mode, generating methods that were not affected by force mocking.
Additionally, there was a bug with parametrized test generation trying to use private inner class as a type for one of the parameters.
Fixes # (591, 596)
Type of Change
How Has This Been Tested?
Automated Testing
Run
deepEqualsTestwith enabled parametrized test generation. Verify that the generated test class is not empty (there are methods where force mocking didn't take place), instead of being empty after #573.