Skip to content

An attempt to avoid UtMethod in codegen #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Jul 28, 2022

Description

Using UtMethod<*> makes codegen support for Javascript, Python and Go much more difficult.
We try to create a facade CgMethodTestSet for UtMethodTestSet to use it in all codegen API. This approach allows to reuse our codegen implementation.

Fixes # (621) as a part of refactoring.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated Testing

utbot-samples pipleline

Manual Scenario

regression checks on parametrized tests, including static method under test

@EgorkaKulikov EgorkaKulikov force-pushed the egor/utmethod_codegen branch 2 times, most recently from f350153 to 38a24f8 Compare August 1, 2022 03:38
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review August 1, 2022 05:19
@EgorkaKulikov EgorkaKulikov force-pushed the egor/utmethod_codegen branch from a30112a to c0e57ae Compare August 1, 2022 07:05
@EgorkaKulikov EgorkaKulikov linked an issue Aug 1, 2022 that may be closed by this pull request
Copy link
Collaborator

@ArsenHD ArsenHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple minor changes. Everything is looking good.

@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) August 1, 2022 13:25
@EgorkaKulikov EgorkaKulikov merged commit 83341fd into main Aug 1, 2022
@EgorkaKulikov EgorkaKulikov deleted the egor/utmethod_codegen branch August 1, 2022 14:48
tamarinvs19 pushed a commit that referenced this pull request Aug 4, 2022
* An attempt to avoid UtMethod in codegen

* Fix a bug with param names

* Correcting indices

* Use displayName for executables instead of regular name

* Rename parameter for better readability

Co-authored-by: Arsen Nagdalian <nagoarsen@mail.ru>
denis-fokin pushed a commit that referenced this pull request Aug 18, 2022
* An attempt to avoid UtMethod in codegen

* Fix a bug with param names

* Correcting indices

* Use displayName for executables instead of regular name

* Rename parameter for better readability

Co-authored-by: Arsen Nagdalian <nagoarsen@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Keep names of parameters in the parametrized test
2 participants