Skip to content

Fixed the weird logic in the of error messages in SummaryTestCaseGeneratorTest #383 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

amandelpie
Copy link
Collaborator

@amandelpie amandelpie commented Jul 21, 2022

Description

This PR covers more cases with matching of generated and provided in tests display names, method names and comments
Also, now it prints what's exactly happens and formatted it well.

Also, this ticket is required to start the following ticket #382

Fixes #383

Type of Change

Please delete options that are not relevant.

  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Manual Scenario

Just change something in the tests data for the utbot-summary-test module and you will obtain the formatted well messages.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@amandelpie amandelpie requested a review from onewhl July 21, 2022 14:42
@amandelpie amandelpie enabled auto-merge (squash) July 21, 2022 14:43
Copy link
Member

@onewhl onewhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now output looks more clear, thank you!
I have only one suggestion -- to mark the expected and actual values explicitly.

@amandelpie amandelpie requested a review from onewhl July 25, 2022 10:44
Copy link
Member

@onewhl onewhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@amandelpie amandelpie merged commit c5c3955 into main Jul 25, 2022
@amandelpie amandelpie deleted the amandelpie/feature_383 branch July 25, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrong logic of error messages in List<UtExecution>.checkMatchersWithDisplayNames
2 participants