Skip test generation for abstract methods #550 #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damtev
requested changes
Jul 21, 2022
| @@ -361,6 +362,7 @@ class GenerateTestsDialogWindow(val model: GenerateTestsModel) : DialogWrapper(m | |||
| if (srcClasses.size == 1) { | |||
| items = TestIntegrationUtils.extractClassMethods(srcClasses.single(), false) | |||
| .filterWhen(UtSettings.skipTestGenerationForSyntheticMethods) { it.member !is SyntheticElement } | |||
| .filterNot { it.member.modifierList?.hasModifierProperty(PsiModifier.ABSTRACT)?: false } | |||
There was a problem hiding this comment.
Please, move such a function somewhere in utils.
There was a problem hiding this comment.
Moved to org.utbot.intellij.plugin.util.MemberInfoUtilsKt#isAbstract
| .map { it.summarize(searchDirectory) } | ||
| .filterNot { it.executions.isEmpty() && it.errors.isEmpty() } | ||
| } | ||
| } catch (e: java.lang.IllegalStateException) { |
There was a problem hiding this comment.
Are we really going to catch only IllegalStateException? Maybe, we should catch every exception here? Need to discuss
There was a problem hiding this comment.
As discussed, replaced with runCatching
volivan239
force-pushed
the
volivan239/skip_test_generaton_for_abstract_methods
branch
from
5ad8aae to
ff6f2cd
Compare
Damtev
approved these changes
Jul 28, 2022
volivan239
deleted the
volivan239/skip_test_generaton_for_abstract_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #550
Type of Change
How Has This Been Tested?
Automated Testing
No tests were added.
Manual Scenario
Checklist (remove irrelevant options):