Skip to content

Fix incomplete results in the SARIF report #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

mmvpm
Copy link
Collaborator

@mmvpm mmvpm commented Jul 11, 2022

Description

  • Fixed incorrect highlighted region
  • Fixed incomplete analysis steps

Fixes #460, #470

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

  1. Run test generation using IDEA plugin
  2. Check the created SARIF report. All results should:
  • refer to the correct line in the source code:
    image
  • have the correct Generated test for this case link:
    image
  • have at least 2 (correct) Analysis steps: from the test method and from the source method:
    image

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • All tests pass locally with my changes

@mmvpm mmvpm requested a review from nikitavlaev July 11, 2022 08:30
@mmvpm mmvpm linked an issue Jul 11, 2022 that may be closed by this pull request
@mmvpm mmvpm force-pushed the ideaseeker/fix-incorrect-region-in-sarif branch 2 times, most recently from 9173dae to dbc9633 Compare July 12, 2022 09:37
@mmvpm mmvpm force-pushed the ideaseeker/fix-incorrect-region-in-sarif branch from dbc9633 to 044d399 Compare July 12, 2022 13:23
@mmvpm mmvpm enabled auto-merge (squash) July 12, 2022 14:13
@mmvpm mmvpm force-pushed the ideaseeker/fix-incorrect-region-in-sarif branch from 044d399 to d495c92 Compare July 13, 2022 07:04
@mmvpm mmvpm merged commit 731a2c6 into main Jul 13, 2022
@mmvpm mmvpm deleted the ideaseeker/fix-incorrect-region-in-sarif branch July 13, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incomplete analysis steps in SARIF report Incorrect region in SARIF report
2 participants