assertArrayEquals overload is not found, tests doesn't compile #135 #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
approved these changes
Jul 11, 2022
resolving merge conflict with main branch, use the very last (just added to the list) library with matching name
Vassiliy-Kudryashov
force-pushed
the
Vassiliy-Kudryashov/135-assertarrayequals-overload-is-not-found-tests-doesnt-compile
branch
from
3d5c582 to
94c695a
Compare
Vassiliy-Kudryashov
deleted the
Vassiliy-Kudryashov/135-assertarrayequals-overload-is-not-found-tests-doesnt-compile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JUnit 4.12 is minimal required version for API compatibility reasons.
We detect precise version via library name and its JAR names as fallback.
In case user have JUnit 4.11 or older in project configuration "our" JUnit from Maven should be put in library list upper than old one to provide proper imports in tests
Fixes #135
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Manual Scenario
Add JUnit 4.11 or older in project dependency
Generate tests for examples.PrimitiveArrays, resulting code uses assertArrayEquals(boolean[], boolean[]) that is absent in JUnit 4.11 or older, code won't compile. At first stage of generation JUnit 4.13.2 should be installed and put higher than existing 4.11. As result test code can be compiled successfully.
Checklist (remove irrelevant options):