Support package-private classes and constructors in AssembleModelGenerator #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
force-pushed
the
egor/asmodgen_class_modifier
branch
from
28aba01 to
d8db6ff
Compare
sergeypospelov
approved these changes
Jun 30, 2022
utbot-framework/src/main/kotlin/org/utbot/framework/assemble/AssembleModelGenerator.kt
Outdated
Show resolved
Hide resolved
EgorkaKulikov
force-pushed
the
egor/asmodgen_class_modifier
branch
from
e134901 to
463c227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Classes have package-private modifier by default, it is good enough to construct assemble models.
Java reflection does not allow to call newInstance method for a non-public class, but it may be fixed with
withAccessibilitymodifierFixes # (346)
Type of Change
How Has This Been Tested?
Automated Testing
Run
AssembleModelGeneratorTestsfrom standard pipelineManual Scenario
Could be tested on classes with default modifier of class or it constructors.