Skip to content

Correct asserts on booleans in parametrized tests #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2022

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Assert booleans equality with assertEquals in parametrized tests

Fixes # (248)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

IntExamples.orderCheck from our utbot-samples project

Manual Scenario

Parametrized tests on function that return boolean. Not required if pipline passes.

@EgorkaKulikov EgorkaKulikov requested a review from Damtev June 24, 2022 17:38
@EgorkaKulikov EgorkaKulikov linked an issue Jun 24, 2022 that may be closed by this pull request
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, it looks like a mandatory fix, but I suggest creating a specific version of deepEquals for parameterized tests in the future.

@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) June 27, 2022 10:26
@EgorkaKulikov EgorkaKulikov merged commit 17126eb into main Jun 27, 2022
@EgorkaKulikov EgorkaKulikov deleted the egor/bool-parametrized branch June 27, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Correct asserts on booleans in parametrized tests
2 participants